Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the cancel button on the custom form button partial #1520

Merged
merged 1 commit into from
Jun 12, 2017
Merged

Enable the cancel button on the custom form button partial #1520

merged 1 commit into from
Jun 12, 2017

Conversation

mansam
Copy link
Contributor

@mansam mansam commented Jun 9, 2017

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1440115
as well as other latent bugs on forms using the same partial
where the cancel button was always disabled.

@mansam
Enable the cancel button on the custom form button partial
38f4b06 
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1440115
as well as other latent bugs on forms using the same partial
where the cancel button was always disabled.
@dclarizio dclarizio added the bug label Jun 9, 2017
@miq-bot
Copy link
Member

miq-bot commented Jun 9, 2017

Checked commit mansam@38f4b06 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@dclarizio dclarizio self-assigned this Jun 9, 2017
@mzazrivec mzazrivec self-assigned this Jun 12, 2017
@mzazrivec mzazrivec added this to the Sprint 63 Ending Jun 19, 2017 milestone Jun 12, 2017
@mzazrivec mzazrivec merged commit 1b6021b into ManageIQ:master Jun 12, 2017
simaishi pushed a commit that referenced this pull request Jun 13, 2017
@mzazrivec @simaishi
Merge pull request #1520 from mansam/enable-cancel-button-on-custom-b…
96e0b1a 
…utton-partial

Enable the cancel button on the custom form button partial
(cherry picked from commit 1b6021b)

https://bugzilla.redhat.com/show_bug.cgi?id=1461165
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 96e0b1a15ec2eb6556d63413b263ae39cf2ddd55
Author: Milan Zázrivec <[email protected]>
Date:   Mon Jun 12 12:51:00 2017 +0200

    Merge pull request #1520 from mansam/enable-cancel-button-on-custom-button-partial
    
    Enable the cancel button on the custom form button partial
    (cherry picked from commit 1b6021bde683ea2222abc54a8b08b8d5cdcbd027)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1461165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dclarizio dclarizio

@mzazrivec mzazrivec

Labels
bug fine/backported networks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mansam @miq-bot @simaishi @dclarizio @mzazrivec